remove unnecessary moves from route handlers#581
Merged
yoshuawuyts merged 2 commits intohttp-rs:masterfrom Jun 12, 2020
Merged
Conversation
Fishrock123
approved these changes
Jun 10, 2020
yoshuawuyts
approved these changes
Jun 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tide examples (and code, to the extent that it serves as an extended example) should use
|_| async { … }instead of|_| async move { … }in circumstances where the request is unused. The compiler will let people know when they need to add themove, and|_| async move { Ok("hello") }throughout the examples encourages default use of unnecessary boilerplate.